[ 
https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15359601#comment-15359601
 ] 

Jan Høydahl commented on SOLR-7871:
-----------------------------------

Absolutely, that is what the current patch does. If a certain value is NOT 
explicitly configured in solr.in.sh, it will attempt to load from System Env 
variables, if it does not exist there, it will load from the application 
defaults map (which is going to be initialized from a 
{{solrcliconfig.properties}} inside of {{WEB-INF/classes}}.

Initially I wanted to let environment variables override what was in 
solr.in.sh, but to keep back-compat, I currently do it the other way around. 
Anyways, I think we should ship future releases with a 
{{bin/solr.conf.template}} or {{bin/solr.yml.template}} where all is commented 
out and thus falls back to app defaults, unless people either configure 
environment variabele and/or rename the file to {{bin/solr.conf}}.

> Platform independent config file instead of solr.in.sh and solr.in.cmd
> ----------------------------------------------------------------------
>
>                 Key: SOLR-7871
>                 URL: https://issues.apache.org/jira/browse/SOLR-7871
>             Project: Solr
>          Issue Type: Improvement
>          Components: scripts and tools
>    Affects Versions: 5.2.1
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>              Labels: bin/solr
>             Fix For: 6.0
>
>         Attachments: SOLR-7871.patch
>
>
> Spinoff from SOLR-7043
> The config files {{solr.in.sh}} and {{solr.in.cmd}} are currently executable 
> batch files, but all they do is to set environment variables for the start 
> scripts on the format {{key=value}}
> Suggest to instead have one central platform independent config file e.g. 
> {{bin/solr.yml}} or {{bin/solrstart.properties}} which is parsed by 
> {{SolrCLI.java}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to