Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/49#discussion_r69934693
--- Diff:
lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/ComparisonValueSource.java
---
@@ -0,0 +1,104 @@
+package org.apache.lucene.queries.function.valuesource;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import java.io.IOException;
+import java.util.Map;
+
+import org.apache.lucene.index.LeafReaderContext;
+import org.apache.lucene.queries.function.ValueSource;
+import org.apache.lucene.queries.function.FunctionValues;
+import org.apache.lucene.queries.function.docvalues.BoolDocValues;
+import org.apache.lucene.search.IndexSearcher;
+
+
+/**
+ * Base class for comparison operators used within if statements
+ * To Solr's if function query a 0 is considered "false", all other values
are "true"
+ */
+public abstract class ComparisonValueSource extends BoolFunction {
+
+ private final ValueSource lhs;
+ private final ValueSource rhs;
+ private final String name;
+
+ public ComparisonValueSource(ValueSource lhs, ValueSource rhs, String
name) {
+ this.lhs = lhs;
+ this.rhs = rhs;
+ this.name = name;
+ }
+
+ // Perform the comparison, returning true or false
+ public abstract boolean compare(double lhs, double rhs);
+
+ // Uniquely identify the operation (ie "gt", "lt" "gte", etc)
+ public String name() {
+ return this.name;
+ }
+
+ // string comparison? Probably should be a seperate function
+ // public abstract boolean compareString(String lhs, String rhs);
+
+ public FunctionValues getValues(Map context, LeafReaderContext
readerContext) throws IOException {
+ final FunctionValues lhsVal = this.lhs.getValues(context,
readerContext);
+ final FunctionValues rhsVal = this.rhs.getValues(context,
readerContext);
+ final String compLabel = this.name();
+
+ return new BoolDocValues(this) {
+ @Override
+ public boolean boolVal(int doc) {
+ return compare(lhsVal.floatVal(doc), rhsVal.floatVal(doc));
+ }
+
+ @Override
+ public String toString(int doc) {
+ return compLabel + "(" + lhsVal.toString(doc) + "," +
rhsVal.toString(doc) + ")";
+ }
+ };
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this.getClass() != o.getClass()) return false;
+ if (!(o instanceof ComparisonValueSource)) return false;
--- End diff --
This line is not needed; the classes must be equal in the previous line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
