[
https://issues.apache.org/jira/browse/SOLR-9303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375014#comment-15375014
]
ASF GitHub Bot commented on SOLR-9303:
--------------------------------------
GitHub user paulo-raca opened a pull request:
https://github.com/apache/lucene-solr/pull/51
SOLR-9303: Refactor CloudSolrClient for extensibility
I'm using a custom Solr plugins which adds extra constraints on which nodes
I can access.
To respect these constraints, I needed to use a customized version of
CloudSolrClient.
Unfortunately, CloudSolrClient.sendRequest() is currently written as one
big chunk of code, breaking OO's SOLID principle and making it is impossible
for me to customize it on a subclass.
I have refactored this method in 3 steps:
- Finding the usable URLs
- Checking if a node can be used for this request
- Executing the request
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulo-raca/lucene-solr master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/51.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #51
----
commit c7362262e868b9311e94c954e6e1c9f866776ed2
Author: Paulo Costa <paulo.co...@geofusion.com.br>
Date: 2016-07-13T13:44:24Z
SOLR-9303: Refactor CloudSolrClient for extensibility
CloudSolrClient.sendRequest() is currently written as one big chunk of
code, making it difficult to customize it on a subclass.
----
> Refactor CloudSolrClient for extensibility
> ------------------------------------------
>
> Key: SOLR-9303
> URL: https://issues.apache.org/jira/browse/SOLR-9303
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrJ
> Affects Versions: 5.4, 6.0
> Reporter: Paulo Costa
> Priority: Minor
> Labels: SolrCloud, solrj
> Fix For: 6.1
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I'm using a custom Solr plugins which adds extra constraints on which nodes I
> can access.
> To respect these constraints, I needed to use a customized version of
> CloudSolrClient.
> Unfortunately, CloudSolrClient.sendRequest() is currently written as one big
> chunk of code, breaking OO's SOLID principle and making it is impossible for
> me to customize it on a subclass.
> I suggest we refactor this method in 3 steps:
> - Finding the usable URLs
> - Checking if a node can be used for this request
> - Executing the request
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
