[ 
https://issues.apache.org/jira/browse/LUCENE-7384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384336#comment-15384336
 ] 

David Smiley commented on LUCENE-7384:
--------------------------------------

Before I commit its removal, [~romseygeek] do you recall why these queries 
needed/used the now-defunct ScoringWrapperSpans?

> Remove ScoringWrapperSpans
> --------------------------
>
>                 Key: LUCENE-7384
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7384
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: David Smiley
>         Attachments: LUCENE_7384.patch
>
>
> In LUCENE-6919 (Lucene 5.5), ScoringWrapperSpans was modified in such a way 
> that made the existence of this class pointless, and possibly broke anyone 
> who was using it as it's SimScorer argument isn't used anymore.  We should 
> now delete it.  SpanWeight has getSimScorer() so people can customize the 
> SimScorer that way.
> Another small change I observe to improve is have SpanWeight.buildSimWeight's 
> last line use the existing Similarity that has already been populated on the 
> field?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to