[
https://issues.apache.org/jira/browse/LUCENE-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389648#comment-15389648
]
Michael McCandless commented on LUCENE-7389:
--------------------------------------------
+1
Maybe remove that {{addDocument}} call in the test case, since we now throw the
exc (correctly!) on trying to create the point?
Thanks [~martijn.v.groningen]!
> Validation issue in FieldType#setDimensions?
> --------------------------------------------
>
> Key: LUCENE-7389
> URL: https://issues.apache.org/jira/browse/LUCENE-7389
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Martijn van Groningen
> Attachments: LUCENE-7383.patch
>
>
> It compares if the {{dimensionCount}} is larger than
> {{PointValues.MAX_NUM_BYTES}} while this constant should be compared to
> {{dimensionNumBytes}} instead?
> So this if statement:
> {noformat}
> if (dimensionCount > PointValues.MAX_NUM_BYTES) {
> throw new IllegalArgumentException("dimensionNumBytes must be <= " +
> PointValues.MAX_NUM_BYTES + "; got " + dimensionNumBytes);
> }
> {noformat}
> Should be:
> {noformat}
> if (dimensionNumBytes > PointValues.MAX_NUM_BYTES) {
> throw new IllegalArgumentException("dimensionNumBytes must be <= " +
> PointValues.MAX_NUM_BYTES + "; got " + dimensionNumBytes);
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
