Github user softwaredoug commented on the issue:

    https://github.com/apache/lucene-solr/pull/49
  
    I just think we have to tread carefully. Comparing two 64 bit timestamps 
could result in surprising bugs where an event seconds after another isn't 
greater than the earlier event due to a loss of precision casting to double. So 
I'd rather enforce the safest possible and most correct comparison and make the 
interface not that general.
    
    Is your concern performance based? Can we reduce the number of times we 
call doubleVal/longVal. Sorry I was not aware of the performance implications.
    
    We could also make the values themselves implement Comparable and let them 
be compared to other function values. But this seems complex and we'd still 
need to enforce the correct comparison. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to