[ 
https://issues.apache.org/jira/browse/SOLR-9127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402108#comment-15402108
 ] 

Jan Høydahl commented on SOLR-9127:
-----------------------------------

This patch adds POI to solr core, inside the {{solr-webapp}}, while the 
existing poi dependency was only in {{contrib/extraction}}. I'm not happy about 
this code in Solr at all, but at least make it be a new contrib instead of in 
core!

The wt adds 694 lines of Java code and 597 lines of test config (that is quite 
much more than the 100-lines you were talking about [~noble.paul])
[~desultir], you can easily shrink {{solrconfig-xlsxresponsewriter.xml}} to 
just the few lines needed to setup the wt, delete the rest and use defaults.

Thinking about the configuration where you currently allow "columnWidths" and 
"columnNames". Instead of going down that route, adding new config such as 
color, height, font, borders etc in the future, why not simply take a file 
argument to a template.xlsx file, and let the first row be column headers, the 
second row be solr field names, and just clone the sheet and keep all other 
formatting?

> XLSX response writer - do we want it?
> -------------------------------------
>
>                 Key: SOLR-9127
>                 URL: https://issues.apache.org/jira/browse/SOLR-9127
>             Project: Solr
>          Issue Type: Improvement
>          Components: Response Writers
>            Reporter: Tony Moriarty
>            Priority: Minor
>             Fix For: 5.5, 6.0
>
>
> I recently open sourced an XLSX response writer based on solr 4.6 and apache 
> poi.
> https://github.com/desultir/SolrXLSXResponseWriter
> Is this something the community would be interested in bringing into the solr 
> codebase? I'm willing to put the work into porting it to solr5 and solr6 if 
> the community is interested, happy to leave it as a plugin otherwise.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to