[ https://issues.apache.org/jira/browse/SOLR-8396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426307#comment-15426307 ]
Adrien Grand commented on SOLR-8396: ------------------------------------ {code} +// nocommit: Remove this wrap +// if (getFieldInfos().hasPointValues()) { +// throw new IllegalArgumentException("cannot wrap points"); +// } {code} Now that SlowCompositeReaderWrapper is Solr-specific, I think it would be fine to remove this check and move th exception to #getPointValues. That should fix the problem? > Add support for PointFields in Solr > ----------------------------------- > > Key: SOLR-8396 > URL: https://issues.apache.org/jira/browse/SOLR-8396 > Project: Solr > Issue Type: Improvement > Reporter: Ishan Chattopadhyaya > Attachments: SOLR-8396.patch, SOLR-8396.patch, SOLR-8396.patch, > SOLR-8396.patch, SOLR-8396.patch, SOLR-8396.patch, SOLR-8396.patch > > > In LUCENE-6917, [~mikemccand] mentioned that DimensionalValues are better > than NumericFields in most respects. We should explore the benefits of using > it in Solr and hence, if appropriate, switch over to using them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org