[
https://issues.apache.org/jira/browse/SOLR-9412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-9412:
--------------------------------------
Attachment: SOLR-9412.patch
Hi Jon, thanks for your patch.
Please find attached some suggested revisions. What do you think?
MacroExpander:
* param/member spell correction
* make the new flag final
* constructor style tweak
TestMacroExpander:
* assertEquals arg order needed swapping
* split out the tests:
** testExamples via its random element tests and shows that existing/example
behavior is unaffected by absence or presence or value of the new parameter
** testOnMissingParams tests the expansion behavior differences, with coverage
expanded (no pun intended) so that either or both of the params could be missing
> Update Macro Expander for replacement logic
> -------------------------------------------
>
> Key: SOLR-9412
> URL: https://issues.apache.org/jira/browse/SOLR-9412
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Jon Dorando
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-9412.patch, test_macro_expander.patch
>
>
> MacroExpander class was updated to allow to return null when replacement
> parameters are missing. Right now it defaults to a blank space and it isn't
> easily verifiable that a parameter was missing. Additionally, unit tests were
> added for this case and the original use cases of Macro Expander.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
