[ 
https://issues.apache.org/jira/browse/LUCENE-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437120#comment-15437120
 ] 

Adrien Grand commented on LUCENE-7416:
--------------------------------------

The part that rewrites boolean queries into a MatchNoDocsQuery if some clauses 
are bothe excluded and required is indeed broken on 6.x because of queryNorm. 
I'm leaning towards not having this rewrite rule on 6.x to keep things simple 
rather than checking the coord values. This is already complicated enough. I'll 
do that for now to get the tests passing again.

[~thetaphi] +1 to your patch

> BooleanQuery rewrite optimizations
> ----------------------------------
>
>                 Key: LUCENE-7416
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7416
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>    Affects Versions: master (7.0)
>            Reporter: Spyros Kapnissis
>            Priority: Minor
>             Fix For: master (7.0), 6.3
>
>         Attachments: LUCENE-7146-simplific1.patch, 
> LUCENE-7146-simplific1.patch, LUCENE-7146.patch
>
>
> A couple of BooleanQuery rewrites / optimizations. 
> First, as discussed on the user group, a BooleanQuery with a query that is 
> both a SHOULD and a FILTER can be rewritten as a single MUST query, but care 
> must be taken to decrement minShouldMatch by 1.
> Another case is if a query is both required (MUST or FILTER) and MUST_NOT at 
> the same time, it can be converted to a MatchNoDocsQuery (although I haven't 
> discussed this yet so hopefully I'm not missing something!).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to