[ 
https://issues.apache.org/jira/browse/SOLR-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437204#comment-15437204
 ] 

Shawn Heisey commented on SOLR-9371:
------------------------------------

I didn't notice SOLR-8605.  If I had, I would have put the patch there.

[~markrmil...@gmail.com] makes a very good point in his last comment on that 
issue.  Perhaps the default timeout should be something really long.  Initial 
bikeshed: maybe 3 minutes, same as Collections API?  I did increase it in my 
patch, to 60 seconds.

A non-windows system *will* exit earlier than the timeout if shutdown happens 
faster, and with my proposed patch, the user has the option of changing the 
timeout to make the hard kill happen faster if they want.

Opening a separate issue for Windows seems prudent.  It needs some work before 
we can increase the default timeout.


> Fix bin/solr script calculations - start/stop wait time and RMI_PORT
> --------------------------------------------------------------------
>
>                 Key: SOLR-9371
>                 URL: https://issues.apache.org/jira/browse/SOLR-9371
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: scripts and tools
>    Affects Versions: 6.1
>            Reporter: Shawn Heisey
>            Assignee: Shawn Heisey
>            Priority: Minor
>             Fix For: 6.2, master (7.0)
>
>         Attachments: SOLR-9371.patch, SOLR-9371.patch
>
>
> The bin/solr script doesn't wait long enough for Solr to stop before it sends 
> the KILL signal to the process.  The start could use a longer wait too.
> Also, the RMI_PORT is calculated by simply prefixing the port number with a 
> "1" instead of adding 10000.  If the solr port has five digits, then the rmi 
> port will be invalid, because it will be greater than 65535.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to