[ https://issues.apache.org/jira/browse/SOLR-8487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439454#comment-15439454 ]
Kevin Risden commented on SOLR-8487: ------------------------------------ I like the commit() outside update(). This makes commit look more like a count or something similar. One thing that may be useful is amount of time passed (I know this makes it harder): Lets say the underlying stream is a daemon that happens every 30 seconds. If you set the batch size to 1 that would work but maybe you want to commit every 1000 tuples or every 5 minutes. I guess at that point you could instead have Solr doing the auto commit. Just a thought. > Add CommitStream to Streaming API and Streaming Expressions > ----------------------------------------------------------- > > Key: SOLR-8487 > URL: https://issues.apache.org/jira/browse/SOLR-8487 > Project: Solr > Issue Type: New Feature > Affects Versions: 6.0 > Reporter: Jason Gerlowski > Priority: Minor > Fix For: 6.0 > > Attachments: SOLR-8487.patch > > > (Paraphrased from Joel's idea/suggestions in the comments of SOLR-7535). > With SOLR-7535, users can now index documents/tuples using an UpdateStream. > However, there's no way currently using the Streaming API to force a commit > on the collection that received these updates. > The purpose of this ticket is to add a CommitStream, which can be used to > trigger commit(s) on a given collection. > The proposed usage/behavior would look a little bit like: > {{commit(collection, parallel(update(search()))}} > Note that... > 1.) CommitStream has a positional collection parameter, to indicate which > collection to commit on. (Alternatively, it could recurse through > {{children()}} nodes until it finds the UpdateStream, and then retrieve the > collection from the UpdateStream). > 2.) CommitStream forwards all tuples received by an underlying, wrapped > stream. > 3.) CommitStream commits when the underlying stream emits its EOF tuple. > (Alternatively, it could commit every X tuples, based on a parameter). -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org