[
https://issues.apache.org/jira/browse/SOLR-7850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467332#comment-15467332
]
David Smiley commented on SOLR-7850:
------------------------------------
This issue recently came up in the context of the official Solr docker image:
https://github.com/docker-solr/docker-solr/issues/55#issuecomment-244907190
The solr.in.sh script is mostly commented but there are exceptions, such as
setting SOLR_HEAP. As-such, this will over-ride any existing environment
variable definition for this, leading to a bad user experience. My preference
would be for the default settings to be embedded within the bin/solr script as
conditionals (i.e. only define these vars if they are not already defined).
The bin/solr script _already_ does this for a ton of stuff, so this approach is
very consistent -- a good thing. At that point, we can comment out everything
that isn't already commented out in solr.in.sh.
Perhaps the issue title could be renamed to "The default solr.in.sh shouldn't
do anything; add more defaults to bin/solr" if we agree on this.
> Move user customization out of solr.in.* scripts
> ------------------------------------------------
>
> Key: SOLR-7850
> URL: https://issues.apache.org/jira/browse/SOLR-7850
> Project: Solr
> Issue Type: Improvement
> Components: scripts and tools
> Affects Versions: 5.2.1
> Reporter: Shawn Heisey
> Priority: Minor
>
> I've seen a fair number of users customizing solr.in.* scripts to make
> changes to their Solr installs. I think the documentation suggests this,
> though I haven't confirmed.
> One possible problem with this is that we might make changes in those scripts
> which such a user would want in their setup, but if they replace the script
> with the one in the new version, they will lose their customizations.
> I propose instead that we have the startup script look for and utilize a user
> customization script, in a similar manner to linux init scripts that look for
> /etc/default/packagename, but are able to function without it. I'm not
> entirely sure where the script should live or what it should be called. One
> idea is server/etc/userconfig.\{sh,cmd\} ... but I haven't put a lot of
> thought into it yet.
> If the internal behavior of our scripts is largely replaced by a small java
> app as detailed in SOLR-7043, then the same thing should apply there -- have
> a config file for a user to specify settings, but work perfectly if that
> config file is absent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
