[ https://issues.apache.org/jira/browse/SOLR-9484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487416#comment-15487416 ]
Shalin Shekhar Mangar commented on SOLR-9484: --------------------------------------------- Thanks Dat. A few comments: # The Thread.sleep should move to end of the loop instead of the start. This is so that the first iteration doesn't sleep unnecessarily. # The DocCollection variable is named "clusterProps". Cluster props indicate that this is a cluster property but it is not. It should be called collection instead. # The "isEquals" doesn't indicate its purpose very well. Perhaps better to rename it as "isCollectionModified" or maybe "areChangesVisible"? > The modify collection API should wait for the modified properties to show up > in the cluster state > ------------------------------------------------------------------------------------------------- > > Key: SOLR-9484 > URL: https://issues.apache.org/jira/browse/SOLR-9484 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud > Affects Versions: 6.2 > Reporter: Shalin Shekhar Mangar > Assignee: Cao Manh Dat > Labels: difficulty-easy, impact-medium > Fix For: 6.3, master (7.0) > > Attachments: SOLR-9484.patch > > > The modify collection API doesn't wait for the updated properties to show up > in the cluster state. Say you increase the maxShardsPerNode for a collection > using this API, if you try to add a replica immediately after modify > collection API returns then the overseer sometimes doesn't see the updated > property and refuses to add a new replica. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org