[ https://issues.apache.org/jira/browse/SOLR-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15497717#comment-15497717 ]
Michael Sun commented on SOLR-9519: ----------------------------------- Here is a patch. It basically does a check if a zero domain has any sub-facet that can alter domain. > Check sub-facets of empty facet buckets for operations that may expand the > domain (like filter exclusions) > ---------------------------------------------------------------------------------------------------------- > > Key: SOLR-9519 > URL: https://issues.apache.org/jira/browse/SOLR-9519 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module > Reporter: Yonik Seeley > Attachments: SOLR-9519.patch > > > http://markmail.org/message/bgplt2qdxc7gqga5 > {quote} > Background: the JSON Facet API does not execute sub-facets for a facet > bucket with a 0 count (and the root facet bucket is like any other > facet bucket). > This was to help prevent the combinatorial explosion of deeply nested > sub-facets with useless information. > This is obviously incorrect though, when a sub-facet does something > that can expand the domain rather than just restrict it. Facet > exclusions are one of these cases. > For zero facet buckets, we should check if any sub-facets have these > properties and then recurse if so. > {quote} > Aside: not processing empty sets also helped with issues like what junk > values to fill in for statistics... min, max, average, std, etc. JSON > doesn't even officially support NaN, so it's nice to be able to leave these > junk values out in many circumstances. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org