[
https://issues.apache.org/jira/browse/SOLR-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516821#comment-15516821
]
Shalin Shekhar Mangar commented on SOLR-6090:
---------------------------------------------
I can understand the point of doDeletes but this stuff is trivial. Log it in
debug level or add it when necessary otherwise it is just code smell to me.
Anyway, if you want to keep it, feel free to revert my commit.
> Remove unreachable printLayout usage in cloud test
> --------------------------------------------------
>
> Key: SOLR-6090
> URL: https://issues.apache.org/jira/browse/SOLR-6090
> Project: Solr
> Issue Type: Task
> Components: SolrCloud, Tests
> Reporter: Shalin Shekhar Mangar
> Assignee: Cao Manh Dat
> Priority: Minor
> Fix For: 6.3, master (7.0)
>
> Attachments: SOLR-6090.patch
>
>
> Many cloud tests have a DEBUG instance variable e.g.
> {code}
> private static final boolean DEBUG = false;
> {code}
> and
> {code}
> if (DEBUG) {
> super.printLayout();
> }
> {code}
> I cannot find where this variable is set to true so the printLayout is never
> actually printed.
> We need to review and fix all such tests:
> # BasicDistributedZKTest.doTest
> # CollectionsAPIAsyncDistributedZkTest.doTest
> # CollectionsAPIDistributedZkTest
> # CustomCollectionTest
> # UnloadDistributedZkTest
> This is not an exhaustive list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
