Michael Braun created SOLR-9585:
-----------------------------------

             Summary: Solr gc log filename should include port number
                 Key: SOLR-9585
                 URL: https://issues.apache.org/jira/browse/SOLR-9585
             Project: Solr
          Issue Type: Improvement
      Security Level: Public (Default Security Level. Issues are Public)
            Reporter: Michael Braun
            Priority: Minor


In our setup, we have two solr applications running on the same box on 
different ports. We are sharing the same distribution folder However, both 
instances log garbage collection to the same file, as shown by these two parts 
from the solr bash shell script (this is from master):

{code}
if [ -f "$SOLR_LOGS_DIR/solr_gc.log" ]; then
  if $verbose ; then
    echo "Backing up $SOLR_LOGS_DIR/solr_gc.log"
  fi
  mv "$SOLR_LOGS_DIR/solr_gc.log" "$SOLR_LOGS_DIR/solr_gc_log_$(date 
+"%Y%m%d_%H%M")"
fi
{code}

{code}
# if verbose gc logging enabled, setup the location of the log file
if [ "$GC_LOG_OPTS" != "" ]; then
  gc_log_flag="-Xloggc"
  if [ "$JAVA_VENDOR" == "IBM J9" ]; then
    gc_log_flag="-Xverbosegclog"
  fi
  GC_LOG_OPTS=($GC_LOG_OPTS "$gc_log_flag:$SOLR_LOGS_DIR/solr_gc.log")
else
  GC_LOG_OPTS=()
fi
{code}

I'm proposing appending the $SOLR_PORT value into the log file name (perhaps 
only if non-default) so we can have both logs in our case. I'm happy to provide 
a patch assuming this direction is desired.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to