[ 
https://issues.apache.org/jira/browse/SOLR-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549240#comment-15549240
 ] 

Alexandre Rafalovitch commented on SOLR-1236:
---------------------------------------------

I get 77 files, when I run:
{noformat}
ack "java.io.File;" --type java --ignore-dir="test-framework" 
--ignore-dir="test" |wc -l
{noformat}

I would say we are not ready for forbidden-api for this one. I am not sure if 
that means we should have a different issue(s) open for this discovery.

But the "Strings" issue is probably done as a specific "next-action" issue. If 
there is no further objections, I will close it.

> stop using strings for filepaths and start using File objects
> -------------------------------------------------------------
>
>                 Key: SOLR-1236
>                 URL: https://issues.apache.org/jira/browse/SOLR-1236
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>            Priority: Trivial
>
> Catching up on my email after a long hiatus i notice SOLR-1213 and it 
> reminded me that the last time i was digging arround in the code i was 
> frustrated by lots of places in Solr where "String" instances to store a file 
> or directory paths and then manipulated with String operations.  I would be 
> nice to switch all of these member variables and and function params to use 
> genuine File objects to improve the code base readibility, and reduce the 
> likelyhood of OS variant bugs or nonsensical path operations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to