[
https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026794#comment-13026794
]
Mark Miller commented on SOLR-2191:
-----------------------------------
bq. Why didn't you simply commit it? I heard on the dev list recently that Solr
is supposedly CTR (commit then review), yet we clearly act here as RTC.
Depends really - on the change and on the committer. We like to keep trunk
extra shiny, and I think our practice is good myself. But it's up to each
committer.
bq. So even if RTC is it, wouldn't there be some threshold to let simple things
like this through without a review?
Yes - and many small things are simply committed. Likely when I ran into this,
I was doing other things - and I made a quick patch, but not something I was
willing to stake my name on as a commit. I like to do a thorough review first.
And then this just fell off my radar. Sometimes you are just not sure of all of
the ramifications of your change - a lot of times this is a mini side track
while I'm doing something else, and so it's nice to just toss up a patch and
get feedback from the likes of Hossman and others before just cowboying on
trunk. Again though - each situation is handled by each committer based on
their level of comfort, and the general culture of the community.
Yeah, this bug is annoying - I'm happy to look at this again soon - I happen to
be unusually busy at this time, but I'll certainly try to get this in by this
weekend.
> Change SolrException cstrs that take Throwable to default to
> alreadyLogged=false
> --------------------------------------------------------------------------------
>
> Key: SOLR-2191
> URL: https://issues.apache.org/jira/browse/SOLR-2191
> Project: Solr
> Issue Type: Bug
> Reporter: Mark Miller
> Fix For: Next
>
> Attachments: SOLR-2191.patch
>
>
> Because of misuse, many exceptions are now not logged at all - can be painful
> when doing dev. I think we should flip this setting and work at removing any
> double logging - losing logging is worse (and it almost looks like we lose
> more logging than we would get in double logging) - and bad
> solrexception/logging patterns are proliferating.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
