[
https://issues.apache.org/jira/browse/SOLR-9629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15567600#comment-15567600
]
Shawn Heisey commented on SOLR-9629:
------------------------------------
What's the rationale of changing the Long creation in BinaryRequestWriter to a
cast to the primitive type? Java will need to autobox the long to Long in
order to return the value.
I'm not saying the change is wrong, because I honestly do not know which way
has better performance or fits better with Java norms ... I just would like to
know why that change is there. I don't see any warning on the code in eclipse,
which typically has many more warnings than javac.
> Fix SolrJ warnings and use of deprecated methods in
> org.apache.solr.client.solrj.impl package
> ---------------------------------------------------------------------------------------------
>
> Key: SOLR-9629
> URL: https://issues.apache.org/jira/browse/SOLR-9629
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrJ
> Affects Versions: master (7.0)
> Reporter: Michael Braun
> Priority: Trivial
> Attachments: SOLR-9629.patch
>
>
> There are some warnings (generic types and deprecation) that appear in the
> org.apache.solr.client.solrj.impl package which can be easily fixed. Other
> than some simple fixes, includes a fix to use a MultiPartEntityBuilder to
> create rather than using a deprecated constructor on MultiPartEntity.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
