[
https://issues.apache.org/jira/browse/LUCENE-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027428#comment-13027428
]
Michael Busch commented on LUCENE-3023:
---------------------------------------
Just a few minor comments, otherwise +1 to commit! (I'm super excited this is
finally happening after the branch was created a year ago or so!)
* In DocumentsWriterPerThreadPool:
remove: {code}
+ //public abstract void clearThreadBindings(ThreadState perThread);
+
+ //public abstract void clearAllThreadBindings();
+
{code}
* In ThreadAffinityDocumentsWriterThreadPool#getAndLock() we had talked about
switching from a per-threadstate queue (safeway model) to a single queue (whole
foods). I'm wondering if we should do that before we commit or change that
later as a separate patch?
* remove some commented out code in TestFlushByRamOrCountsPolicy#testHealthyness
> Land DWPT on trunk
> ------------------
>
> Key: LUCENE-3023
> URL: https://issues.apache.org/jira/browse/LUCENE-3023
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: CSF branch, 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 4.0
>
> Attachments: LUCENE-3023-svn-diff.patch,
> LUCENE-3023-ws-changes.patch, LUCENE-3023.patch, LUCENE-3023.patch,
> LUCENE-3023.patch, LUCENE-3023.patch, LUCENE-3023_CHANGES.patch,
> LUCENE-3023_CHANGES.patch, LUCENE-3023_iw_iwc_jdoc.patch,
> LUCENE-3023_simonw_review.patch, LUCENE-3023_svndiff.patch,
> LUCENE-3023_svndiff.patch, diffMccand.py, diffSources.patch,
> diffSources.patch, realtime-TestAddIndexes-3.txt,
> realtime-TestAddIndexes-5.txt,
> realtime-TestIndexWriterExceptions-assert-6.txt,
> realtime-TestIndexWriterExceptions-npe-1.txt,
> realtime-TestIndexWriterExceptions-npe-2.txt,
> realtime-TestIndexWriterExceptions-npe-4.txt,
> realtime-TestOmitTf-corrupt-0.txt
>
>
> With LUCENE-2956 we have resolved the last remaining issue for LUCENE-2324 so
> we can proceed landing the DWPT development on trunk soon. I think one of the
> bigger issues here is to make sure that all JavaDocs for IW etc. are still
> correct though. I will start going through that first.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
