[ 
https://issues.apache.org/jira/browse/SOLR-9621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15602465#comment-15602465
 ] 

Michael Braun edited comment on SOLR-9621 at 10/24/16 4:19 PM:
---------------------------------------------------------------

Found the forbidden files. Should I attach just a patch from the previous of 
adding those lines, or include a new patch with the forbidden signature files 
affected as well?


was (Author: mbraun688):
Found the forbidden files. Should I commit just a patch from the previous of 
adding those lines, or include a new patch with the forbidden signature files 
affected as well?

> Remove several guava, apache commons calls in favor of java 8 alternatives
> --------------------------------------------------------------------------
>
>                 Key: SOLR-9621
>                 URL: https://issues.apache.org/jira/browse/SOLR-9621
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Michael Braun
>            Priority: Trivial
>         Attachments: SOLR-9621.patch
>
>
> Now that Solr is against Java 8, we can take advantage of replacing some 
> guava and apache commons calls with JDK standards. I'd like to start by 
> replacing the following:
> com.google.common.base.Supplier  -> java.util.function.Supplier
> com.google.common.base.Predicate -> java.util.function.Predicate
> com.google.common.base.Charsets -> java.nio.charset.StandardCharsets
> org.apache.commons.codec.Charsets -> java.nio.charset.StandardCharsets
> com.google.common.collect.Ordering -> java.util.Comparator
> com.google.common.base.Joiner -> java.util.stream.Collectors::joining
> com.google.common.base.Function -> java.util.function.Function
> com.google.common.base.Preconditions::checkNotNull -> 
> java.util.Objects::requireNonNull
> com.google.common.base.Objects::equals -> java.util.Objects::equals
> com.google.common.base.Objects::hashCode -> java.util.Objects::hashCode



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to