[ 
https://issues.apache.org/jira/browse/SOLR-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15608956#comment-15608956
 ] 

Noble Paul commented on SOLR-8332:
----------------------------------

bq. The transformer's constructor may take a SolrQueryRequest argument (if 
needed) and that way request param deciphering happens only once per 
prepDistributed call.

Creating a new instance of {{ReplicaListTransformer}} for each request is 
wasteful. That is why added the request object as a parameter to each call. 
This way you can manage with a singleton

> factor HttpShardHandler[Factory]'s url shuffling out into a 
> ReplicaListTransformer class
> ----------------------------------------------------------------------------------------
>
>                 Key: SOLR-8332
>                 URL: https://issues.apache.org/jira/browse/SOLR-8332
>             Project: Solr
>          Issue Type: Wish
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-8332.patch, SOLR-8332.patch, SOLR-8332.patch
>
>
> Proposed patch against trunk to follow. No change in behaviour intended. This 
> would be as a step towards SOLR-6730.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to