[ 
https://issues.apache.org/jira/browse/SOLR-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609397#comment-15609397
 ] 

Hrishikesh Gadre commented on SOLR-8587:
----------------------------------------

[~yo...@apache.org] [~shaie] Ok I confirmed that the above mentioned approach 
fixes the NoSuchFileException for the segments file. Please refer to this quick 
patch,

https://github.com/hgadre/lucene-solr/commit/e780f63d4ce79b30f3379df3eb59021394080cc8

One open question at this point,

If we fetch the IndexCommit via solrCore.getDeletionPoplicy().getLatestCommit() 
API, then should we be using the corresponding IndexReader instance (instead of 
IndexSearcher.getIndexReader()) ?. Otherwise we may get inconsistent results. 
But after reviewing the code, it looks like IndexCommit.getReader() method may 
return null value. So I am not sure if we can rely on it. Any thoughts on this?

> Add segments file information to core admin status
> --------------------------------------------------
>
>                 Key: SOLR-8587
>                 URL: https://issues.apache.org/jira/browse/SOLR-8587
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>             Fix For: 5.5, 6.0
>
>         Attachments: SOLR-8587.patch, SOLR-8587.patch
>
>
> Having the index's segments file name returned by CoreAdminHandler STATUS can 
> be useful. The info I'm thinking about is the segments file name and its 
> size. If you record that from time to time, in a case of crisis, when u need 
> to restore the index and may not be sure which copy you need to restore, this 
> tiny piece of info can be very useful, as the segmentsN file records the 
> commit point, and therefore what you core reported and what you see at hand 
> can help you make a safer decision.
> I also think it's useful info in general, e.g. probably even more than 
> 'version', and it doesn't add much complexity to the handler or the response.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to