[
https://issues.apache.org/jira/browse/SOLR-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611603#comment-15611603
]
Judith Silverman commented on SOLR-9660:
----------------------------------------
Christine, thanks for the detailed explanations.
> On balance my preference in this scenario would be to not rewrite the old
> constructors since the constructor initialising num and offset members based
> on the initial values of those very members seems unusual?
Indeed. We could instead define default values as consts and do this:
public SortSpec(Sort sort, List<SchemaField> fields)
{
this(sort, fields, DEFAULT_NUM, DEFAULT_OFFSET);
}
Re a 4-parameter weightSortSpec(): I didn't mean to get rid of the 2-parameter
version but to rewrite it in terms of a 4-parameter one:
public SortSpec weightSortSpec(SortSpec originalSortSpec, Sort nullEquivalent)
{
return weightSortSpec( originalSortSpec, nullEquivalent,
sortSpec.getCount(), sortSpec.getOffset() );
}
Thanks for the link to SOLR-9412; will check it out.
Judith
> in GroupingSpecification factor [group](sort|offset|limit) into
> [group](sortSpec)
> ---------------------------------------------------------------------------------
>
> Key: SOLR-9660
> URL: https://issues.apache.org/jira/browse/SOLR-9660
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-9660.patch, SOLR-9660.patch
>
>
> This is split out and adapted from and towards the SOLR-6203 changes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
