Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476827
--- Diff:
solr/solrj/src/test/org/apache/solr/client/solrj/io/stream/JDBCStreamTest.java
---
@@ -354,8 +354,8 @@ public void
testJDBCSolrInnerJoinExpressionWithProperties() throws Exception{
+ " rating_f as rating"
+ " ),"
+ " select("
- + " jdbc(connection=\"jdbc:hsqldb:mem:.\", sql=\"select
PEOPLE.ID as PERSONID, PEOPLE.NAME, COUNTRIES.COUNTRY_NAME from PEOPLE inner
join COUNTRIES on PEOPLE.COUNTRY_CODE = COUNTRIES.CODE order by PEOPLE.ID\",
sort=\"ID asc\", get_column_name=true),"
- + " ID as personId,"
+ + " jdbc(connection=\"jdbc:hsqldb:mem:.\", sql=\"select
PEOPLE.ID as PERSONID, PEOPLE.NAME, COUNTRIES.COUNTRY_NAME from PEOPLE inner
join COUNTRIES on PEOPLE.COUNTRY_CODE = COUNTRIES.CODE order by PEOPLE.ID\",
sort=\"PERSONID asc\", get_column_name=true),"
--- End diff --
Need to fix comment a few lines up from here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
