[
https://issues.apache.org/jira/browse/SOLR-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15622219#comment-15622219
]
Yonik Seeley commented on SOLR-9681:
------------------------------------
Now that you've made me think about it... I'm definitely on the fence, and
perhaps closer to the "just put it in domain" side. Anyone else have thoughts?
This is the right time to think about this minor API stuff, and then stick to
it for the long haul!
"domain" is only for non-narrowing domain changes:
- If filtering will be used a lot by itself, then it's simpler not to have to
enclose it in an extra "domain"
"domain" is for *all* domain changes prior to faceting:
- If filtering will primarily be used with things like blockChildren, "domain"
will already exist, and it's natural for the additional child filters to go
right there.
- The *only* "narrowing" way to change the domain (other than faceting itself),
is "filter". There are unlikely to be others in the future, and thus having a
separate class/distinction at the syntactic level does not seem important.
> add filter to any facet
> -----------------------
>
> Key: SOLR-9681
> URL: https://issues.apache.org/jira/browse/SOLR-9681
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Facet Module
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: master (7.0), 6.4
>
> Attachments: SOLR-9681.patch
>
>
> For the JSON Facet API, we should be able to add a list of filters to any
> facet. These would be applied after any domain changes, hence useful for
> parent->child mapping that would otherwise match all children of any parent
> (SOLR-9510)
> The API should also be consistent with "filter" at the top level of the JSON
> Request API (examples at http://yonik.com/solr-json-request-api/ )
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
