[ 
https://issues.apache.org/jira/browse/SOLR-9659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643903#comment-15643903
 ] 

Alan Woodward commented on SOLR-9659:
-------------------------------------

bq. this patch adds a significant amount of new code to Solr

It's not that big, is it?  The follow-up patch is a lot bigger, but that's 
mainly removing code that already does what this does, only duplicated in 
multiple places, and wrong in a couple of them.

If people are really against this, then I'll close the ticket.  But I think 
it's a significant improvement, and I don't see any other ways of doing this 
incrementally.

> Add zookeeper DataWatch API
> ---------------------------
>
>                 Key: SOLR-9659
>                 URL: https://issues.apache.org/jira/browse/SOLR-9659
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>         Attachments: SOLR-9659.patch
>
>
> We have several components which need to set up watches on ZooKeeper nodes 
> for various aspects of cluster management.  At the moment, all of these 
> components do this themselves, leading to large amounts of duplicated code, 
> and complicated logic for dealing with reconnections, etc, scattered across 
> the codebase.  We should replace this with a simple API controlled by 
> SolrZkClient, which should make the code more robust, and testing 
> considerably easier.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to