[ 
https://issues.apache.org/jira/browse/SOLR-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645182#comment-15645182
 ] 

Yonik Seeley commented on SOLR-9633:
------------------------------------

OK, thanks for the explanation.  That's clearer after I apply the patch too.
Things look good... I think the only minor change I'd make is to wrap the other 
update to ramBytes in the put() method with the "ramUpperWatermark != 
Long.MAX_VALUE" check as you did in other places.

> Limit FastLRUCache by RAM Usage
> -------------------------------
>
>                 Key: SOLR-9633
>                 URL: https://issues.apache.org/jira/browse/SOLR-9633
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Shalin Shekhar Mangar
>             Fix For: 6.3, master (7.0)
>
>         Attachments: SOLR-9633.patch
>
>
> SOLR-7372 added a maxRamMB parameter to LRUCache to evict items based on 
> memory usage. That helps with the query result cache but not with the filter 
> cache which defaults to FastLRUCache. This issue intends to add the same 
> feature to FastLRUCache.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to