[ https://issues.apache.org/jira/browse/LUCENE-7274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669850#comment-15669850 ]
Tommaso Teofili edited comment on LUCENE-7274 at 11/16/16 12:05 PM: -------------------------------------------------------------------- Hi [~caomanhdat], thanks for your patch. A couple of comments: - I think it'd be good if we could make it a {{LogisticRegressionClassifier}} and then extend it into a {{LogisticRegressionDocumentClassifier}} (like for {{KNearestNeighbourClassifier}}. - IIUTC this implementation assumes each feature is stored in a separate field and the weights to be computed externally as a _double[]_ , can this work for example with Solr's capabilities to store AI models ? - regarding the labels, wouldn't it be better to declare the classifier as a {{Classifier<Boolean>}} (it's a binary classifier in the end)? - the changes to NumericDocValues, FloatDocValues and DoubleDocValues break some lucene/core tests as it seems your patched NumericDocValues always returns a Long while FloatDV and DoubleDV convert such a Long value to an Integer and then back to a Float / Double using Float.intBitsToFloat / Double.intBitsToDouble, can you clarify if / why that is needed ? was (Author: teofili): Hi [~caomanhdat], thanks for your patch. A couple of comments: - I think it'd be good if we could make it a {{LogisticRegressionClassifier}} and then extend it into a {{LogisticRegressionDocumentClassifier}} (like for {{KNearestNeighbourClassifier}}. - IIUTC this implementation assumes each feature is stored in a separate field and the weights to be computed externally as a _double[]_ , can this work for example with Solr's capabilities to store AI models ? - regarding the labels, wouldn't it be better to declare the classifier as a {{Classifier<Boolean>}} (it's a binary classifier in the end)? > Add LogisticRegressionDocumentClassifier > ---------------------------------------- > > Key: LUCENE-7274 > URL: https://issues.apache.org/jira/browse/LUCENE-7274 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/classification > Reporter: Cao Manh Dat > Assignee: Tommaso Teofili > Attachments: LUCENE-7274.patch > > > Add LogisticRegressionDocumentClassifier for Lucene. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org