Github user Timothy055 commented on the pull request:

    
https://github.com/apache/lucene-solr/commit/a62fba7a4ebdf7b46b12ef017fc89816ae709935#commitcomment-19911929
  
    In 
solr/core/src/java/org/apache/solr/handler/component/HighlightComponent.java:
    In 
solr/core/src/java/org/apache/solr/handler/component/HighlightComponent.java on 
line 91:
    Unfortunately, quite a few tests depend on this and it'd take a bit of work 
across the rest of the highlighters to migrate to this right now.  As it is it 
continues to support existing use cases, but the deprecation warns folks that 
in the future it might not be safe to assume the highlighter can't be 
overridden through per request parameters. Does that work for now?  I can open 
another ticket to pursue refactoring the rest.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to