Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/107#discussion_r89039004
--- Diff:
solr/core/src/java/org/apache/solr/handler/component/HighlightComponent.java ---
@@ -184,6 +185,20 @@ public void process(ResponseBuilder rb) throws
IOException {
}
}
+ /**
+ * Normalizes parameters between highlighters
+ */
+ private SolrParams normalizeParameters(SolrParams params) {
--- End diff --
You've coded this such that SIMPLE_PRE overrides TAG_PRE which is not what
we want I think? Furthermore, this is coded such that it only overrides at the
global level which won't work for field-specific settings like
`f.myfieldname.hl.tag.pre` which we'd want to examine
`f.myfieldname.hl.simple.pre`. I appreciate where you were going with this,
but in light of the latter point, I think you should simply modify the Solr UH
adapter to lookup say "pre" like so:
String preTag = params.getFieldParam(fieldName,
HighlightParams.TAG_PRE,
params.getFieldParam(fieldName, HighlightParams.SIMPLE_PRE,
"<em>");
);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
