[ https://issues.apache.org/jira/browse/SOLR-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15685594#comment-15685594 ]
ASF GitHub Bot commented on SOLR-9708: -------------------------------------- Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/107#discussion_r89039004 --- Diff: solr/core/src/java/org/apache/solr/handler/component/HighlightComponent.java --- @@ -184,6 +185,20 @@ public void process(ResponseBuilder rb) throws IOException { } } + /** + * Normalizes parameters between highlighters + */ + private SolrParams normalizeParameters(SolrParams params) { --- End diff -- You've coded this such that SIMPLE_PRE overrides TAG_PRE which is not what we want I think? Furthermore, this is coded such that it only overrides at the global level which won't work for field-specific settings like `f.myfieldname.hl.tag.pre` which we'd want to examine `f.myfieldname.hl.simple.pre`. I appreciate where you were going with this, but in light of the latter point, I think you should simply modify the Solr UH adapter to lookup say "pre" like so: String preTag = params.getFieldParam(fieldName, HighlightParams.TAG_PRE, params.getFieldParam(fieldName, HighlightParams.SIMPLE_PRE, "<em>"); ); > Expose UnifiedHighlighter in Solr > --------------------------------- > > Key: SOLR-9708 > URL: https://issues.apache.org/jira/browse/SOLR-9708 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) > Components: highlighter > Reporter: Timothy M. Rodriguez > Assignee: David Smiley > Fix For: 6.4 > > > This ticket is for creating a Solr plugin that can utilize the new > UnifiedHighlighter which was initially committed in > https://issues.apache.org/jira/browse/LUCENE-7438 -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org