[
https://issues.apache.org/jira/browse/SOLR-9788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shalin Shekhar Mangar updated SOLR-9788:
----------------------------------------
Attachment: SOLR_9788.patch
Changes:
* The metric registery is renamed to "solr" from "solrjetty"
* Adds the MetricsServlet to /admin/metrics path -- this lists all the jetty
metrics that we are tracking
* A new SolrMetricsServletContextListener that sets the "solr" MetricRegistry
as a context attribute that is needed for MetricsServlet to work
* The metrics library and its dependencies are now in the server module instead
of core otherwise the metric registry looked up by
SolrMetricsServletContextListener is different (due to them being loaded by
different class loaders)
Now that we have this in place, we can easily hook in the jvm metrics as well
but I won't do that in this issue.
As long as all metrics are registered with the same metric registry, the
/admin/metrics path can display all of our metrics. This will likely not play
well with the changes in SOLR-4735 because that creates a MetricRegistry for
each core. We might need to write our own version of MetricsServlet or write a
wrapper.
> Use instrumented jetty classes
> ------------------------------
>
> Key: SOLR-9788
> URL: https://issues.apache.org/jira/browse/SOLR-9788
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: master (7.0), 6.4
>
> Attachments: SOLR_9788.patch, SOLR_9788.patch
>
>
> Dropwizard metrics library integrated in SOLR-8785 provides a set of
> instrumented equivalents of Jetty classes. This allows us to collect
> statistics on Jetty's connector, thread pool and handlers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
