[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693560#comment-15693560
]
ASF GitHub Bot commented on SOLR-4735:
--------------------------------------
GitHub user sigram opened a pull request:
https://github.com/apache/lucene-solr/pull/119
SOLR-4735 Improve Solr metrics
Branch created from the patch in Jira by Kelvin Wong.
Changes include:
* using shared instances of `MetricRegistry` per core.
* unit test modifications.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sigram/lucene-solr jira/solr-4735
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/119.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #119
----
commit dba0663c79f7b27d4626152d36f8d6d4c62a878d
Author: Andrzej Bialecki <[email protected]>
Date: 2016-11-23T12:48:26Z
Initial patch from Jira.
commit 1ade9c443dbd5b9eae2ec5208b233d28fb20a8cb
Author: Andrzej Bialecki <[email protected]>
Date: 2016-11-24T10:45:20Z
Merge branch 'master' into jira/solr-4735
commit ba2a94fb52d21ed05053a098c8fb9919a469e5b3
Author: Andrzej Bialecki <[email protected]>
Date: 2016-11-24T15:32:04Z
Use SharedMetricRegistries for managing per-core metrics.
----
> Improve Solr metrics reporting
> ------------------------------
>
> Key: SOLR-4735
> URL: https://issues.apache.org/jira/browse/SOLR-4735
> Project: Solr
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Andrzej Bialecki
> Priority: Minor
> Attachments: SOLR-4735.patch, SOLR-4735.patch, SOLR-4735.patch,
> SOLR-4735.patch
>
>
> Following on from a discussion on the mailing list:
> http://search-lucene.com/m/IO0EI1qdyJF1/codahale&subj=Solr+metrics+in+Codahale+metrics+and+Graphite+
> It would be good to make Solr play more nicely with existing devops
> monitoring systems, such as Graphite or Ganglia. Stats monitoring at the
> moment is poll-only, either via JMX or through the admin stats page. I'd
> like to refactor things a bit to make this more pluggable.
> This patch is a start. It adds a new interface, InstrumentedBean, which
> extends SolrInfoMBean to return a
> [[Metrics|http://metrics.codahale.com/manual/core/]] MetricRegistry, and a
> couple of MetricReporters (which basically just duplicate the JMX and admin
> page reporting that's there at the moment, but which should be more
> extensible). The patch includes a change to RequestHandlerBase showing how
> this could work. The idea would be to eventually replace the getStatistics()
> call on SolrInfoMBean with this instead.
> The next step would be to allow more MetricReporters to be defined in
> solrconfig.xml. The Metrics library comes with ganglia and graphite
> reporting modules, and we can add contrib plugins for both of those.
> There's some more general cleanup that could be done around SolrInfoMBean
> (we've got two plugin handlers at /mbeans and /plugins that basically do the
> same thing, and the beans themselves have some weirdly inconsistent data on
> them - getVersion() returns different things for different impls, and
> getSource() seems pretty useless), but maybe that's for another issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
