[ 
https://issues.apache.org/jira/browse/SOLR-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15700686#comment-15700686
 ] 

Joel Bernstein edited comment on SOLR-8593 at 11/28/16 2:07 AM:
----------------------------------------------------------------

Hi [~risdenk] and [~caomanhdat]. I've reviewed the latest work on this ticket 
and it's looking really good!

A couple pieces of functionality that appear to be missing are:

1) Specific handling of SELECT DISTINCT queries. In the current SQLHandler we 
can do MapReduce SELECT DISTINCT queries in parallel on worker nodes. And we 
can also push down the distinct logic to the JSON Facet API.

2) The pushing down of GROUP BY aggregations to the JSON Facet API.

Both of these currently require the aggregationMode parameter to be passed in 
with the query, which I think is fine for the initial Calcite release.

I'd be happy to add these capabilities to this branch. That will also give me 
an opportunity to work with the code and feel comfortable working with Calcite.


 


was (Author: joel.bernstein):
Hi [~risdenk] and [~caomanhdat]. I've reviewed the latest work on this ticket 
and it's looking really good!

A couple pieces of functionality that appear to be missing are:

1) Handling of SELECT DISTINCT queries. In the current SQLHandler we can do 
MapReduce SELECT DISTINCT queries in parallel on worker nodes. And we can also 
push down the distinct logic to the JSON Facet API.

2) The pushing down of GROUP BY aggregations to the JSON Facet API.

Both of these currently require the aggregationMode parameter to be passed in 
with the query, which I think is fine for the initial Calcite release.

I'd be happy to add these capabilities to this branch. That will also give me 
an opportunity to work with the code and feel comfortable working with Calcite.


 

> Integrate Apache Calcite into the SQLHandler
> --------------------------------------------
>
>                 Key: SOLR-8593
>                 URL: https://issues.apache.org/jira/browse/SOLR-8593
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Joel Bernstein
>            Assignee: Joel Bernstein
>         Attachments: SOLR-8593.patch
>
>
>    The Presto SQL Parser was perfect for phase one of the SQLHandler. It was 
> nicely split off from the larger Presto project and it did everything that 
> was needed for the initial implementation.
> Phase two of the SQL work though will require an optimizer. Here is where 
> Apache Calcite comes into play. It has a battle tested cost based optimizer 
> and has been integrated into Apache Drill and Hive.
> This work can begin in trunk following the 6.0 release. The final query plans 
> will continue to be translated to Streaming API objects (TupleStreams), so 
> continued work on the JDBC driver should plug in nicely with the Calcite work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to