[ 
https://issues.apache.org/jira/browse/LUCENE-7572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705397#comment-15705397
 ] 

Adrien Grand commented on LUCENE-7572:
--------------------------------------

bq. Would you mind adding some JavaDocs to PrefixCodedTerms to say this?

I will do that.

bq.  The presence of "delGen" seems out of place having nothing directly to do 
with this utility class's job

Agreed. If something needs a delGen, it should create another object that wraps 
a PrefixCodedTerms instance and the delGen.

bq. And RAMFile shouldn't depend on RAMDirectory

Agreed too, even though that one is a bit less annoying to me since the RAMDir 
and the constructor that sets it are both pkg-private.

> Cache the hashcode of the doc values terms queries
> --------------------------------------------------
>
>                 Key: LUCENE-7572
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7572
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-7572.patch
>
>
> DocValuesNumbersQuery and DocValuesTermsQuery can potentially wrap a large 
> number of terms so it would help if we cached their hashcode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to