[ 
https://issues.apache.org/jira/browse/SOLR-7282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709391#comment-15709391
 ] 

Erick Erickson commented on SOLR-7282:
--------------------------------------

Scott:

My concern has nothing to do with technical capabilities/correctness and 
everything to do with surprising the users and, as an aside, introducing the 
possibilities for error. Introducing such code to support an old version of 
Solr is even less appealing, this sounds like a local patch if you think it's 
worth it. And I'm a little puzzled. You mention "collections", which have 
always had the notion of configsets. Or are you dealing with stand-alone?

If you're really thinking cores and working with stand-alone, if/when you 
upgrade to a Solr that _does_ respect configsets, you should be able to change 
your core.properties files and add the configSet parameter, see: 
https://cwiki.apache.org/confluence/display/solr/Defining+core.properties and 
point them all at the same configset. Then the normal processing we're talking 
about here should work without deciding to reuse based on hashing rather than 
the user's express intent. Changing 4,000 properties files while inelegant 
seems like a _lot_ less work than coding/debugging/maintaining some kind of 
"you said to use X but we're ignoring that because we know better"

Reusing the same internal object based on identical specifications (i.e. the 
user named a particular configset) seems like a fine idea. Doing something 
other than what the user specified because we think we know better to support 
an edge case that there should be other ways of addressing seems unnecessary.

IMO of course.



> Cache config or index schema objects by configset and share them across cores
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-7282
>                 URL: https://issues.apache.org/jira/browse/SOLR-7282
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SolrCloud
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Noble Paul
>             Fix For: 5.2, 6.0
>
>         Attachments: SOLR-7282.patch
>
>
> Sharing schema and config objects has been known to improve startup 
> performance when a large number of cores are on the same box (See 
> http://wiki.apache.org/solr/LotsOfCores).Damien also saw improvements to 
> cluster startup speed upon caching the index schema in SOLR-7191.
> Now that SolrCloud configuration is based on config sets in ZK, we should 
> explore how we can minimize config/schema parsing for each core in a way that 
> is compatible with the recent/planned changes in the config and schema APIs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to