[
https://issues.apache.org/jira/browse/LUCENE-7585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15736501#comment-15736501
]
Ahmet Arslan commented on LUCENE-7585:
--------------------------------------
Thank you for looking into this. Initially, I was planning to move all existing
parameters to a common interface.
I figured that the interface will grow very large since certain factories have
many specific parameters.
I moved the most common parameters to the interface. However, there still
remains a lot in the codebase.
For example, ngram package has "minGramSize" and "maxGramSize" in common.
Phonetic module has "maxCodeLength" and "inject."
What could be the preferred course of action here?
* Handle packages and modules locally? If yes how?
* Move all parameters to the interface unconditionally.
* Devise an algorithm: Move if a parameter is shared by at least two package or
module.
* ?
> Interface for common parameters used across analysis factories
> --------------------------------------------------------------
>
> Key: LUCENE-7585
> URL: https://issues.apache.org/jira/browse/LUCENE-7585
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Affects Versions: 6.3
> Reporter: Ahmet Arslan
> Assignee: David Smiley
> Priority: Minor
> Fix For: master (7.0)
>
> Attachments: LUCENE-7585.patch, LUCENE-7585.patch
>
>
> Certain parameters (String constants) are same/common for multiple analysis
> factories. Some examples are {{ignoreCase}}, {{dictionary}}, and
> {{preserveOriginal}}. These string constants are handled inconsistently in
> different factories. This is an effort to define most common constants in
> ({{CommonAnalysisFactoryParams}}) interface and reuse them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
