[ 
https://issues.apache.org/jira/browse/SOLR-9841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15736889#comment-15736889
 ] 

Erick Erickson commented on SOLR-9841:
--------------------------------------

[~hoss...@fucit.org]

bq: The fact that there is no option prevent any commit at all was a conscious 
choice:

We can quibble about this one I suppose. In many cases it's probably good 
enough to let the next autocommit take care of opening a new searcher and 
rendering the docs un-findable rather than forcing the commit from the code. 
This assumes that the delete-by-query starts an autocommit timer.

If the decision is that we shouldn't/won't make this configurable then we 
should at least change the TODOs

            // TODO: should this be more configurable? 
            // TODO: in particular: should hard commit be optional?
since they make it seem like something that's still an open question. And yes I 
see the distinction between soft and hard commit implicit there.

bq: there is no value add in a new option to prevent the commit from being 
fired – it won't do anything unless there is something to commit.

Well, that's not the original issue, is it? The problem is that we're opening 
multiple searchers in rapid succession apparently due to autocommit expiry 
coupled with this commit. Hmmmm, maybe I'm jumping the gun here and the real 
question is whether the commit from the code resets the autocommit expiry? I 
admit I haven't tracked that bit down. 

I suppose another sequence could be:
- autocommit expires and starts warming a new searcher
- TTL kicks in, deletes some docs and does the commit while the searcher from 
<1> is still warming producing the warning.

All that said, this doesn't seem like a major problem more a tidying-up.

Hmmm, when I hover over the "Create" button the tooltip is "create a new 
issue/bug/feature request", but the drop down is, indeed, Create Service Desk 
Request". Sigh.



> Disable expiration processor commits
> ------------------------------------
>
>                 Key: SOLR-9841
>                 URL: https://issues.apache.org/jira/browse/SOLR-9841
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrCloud
>            Reporter: Brent Pearson
>
> http://lucene.472066.n3.nabble.com/Adding-DocExpirationUpdateProcessorFactory-causes-quot-Overlapping-onDeckSearchers-quot-warnings-td4309155.html
> Need a way to have document expiration update processor *not* trigger 
> additional commits.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to