[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15742740#comment-15742740
]
Jeff Wartes edited comment on SOLR-4735 at 12/12/16 6:38 PM:
-------------------------------------------------------------
I've fallen behind keeping up with your changes, but for what it's worth, I
agree with this. Collection-level metrics are at the cluster level, in
aggregate. It's up to the thing you're reporting the metrics into to do the
aggregation. For example, what I really want on my dashboard in grafana is a
line, something like:
AVG(solr.[all nodes].[all cores belonging to a particular
collection].latency.p95)
Then I can drill into a particular node, or core, in my reporting tool if I
want. There's a requirement that the metrics namespaces being reported allows
for aggregation like this, which might mean a core needs to know the collection
to which it belongs, but I don't think the node itself should needs to report
collection metrics.
was (Author: jwartes):
I've fallen behind keeping up with your changes, but for what it's worth, I
agree with this. Collection-level metrics are at the cluster level, in
aggregate. It's up to the thing you're reporting the metrics into to do the
aggregation. For example, what I really want on my dashboard in grafana is a
line, something like:
AVG(solr.{all nodes}.{all cores belonging to a particular
collection}.latency.p95)
Then I can drill into a particular node, or core, in my reporting tool if I
want. There's a requirement that the metrics namespaces being reported allows
for aggregation like this, which might mean a core needs to know the collection
to which it belongs, but I don't think the node itself should needs to report
collection metrics.
> Improve Solr metrics reporting
> ------------------------------
>
> Key: SOLR-4735
> URL: https://issues.apache.org/jira/browse/SOLR-4735
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: Alan Woodward
> Assignee: Andrzej Bialecki
> Priority: Minor
> Attachments: SOLR-4735.patch, SOLR-4735.patch, SOLR-4735.patch,
> SOLR-4735.patch, screenshot-1.png
>
>
> Following on from a discussion on the mailing list:
> http://search-lucene.com/m/IO0EI1qdyJF1/codahale&subj=Solr+metrics+in+Codahale+metrics+and+Graphite+
> It would be good to make Solr play more nicely with existing devops
> monitoring systems, such as Graphite or Ganglia. Stats monitoring at the
> moment is poll-only, either via JMX or through the admin stats page. I'd
> like to refactor things a bit to make this more pluggable.
> This patch is a start. It adds a new interface, InstrumentedBean, which
> extends SolrInfoMBean to return a
> [[Metrics|http://metrics.codahale.com/manual/core/]] MetricRegistry, and a
> couple of MetricReporters (which basically just duplicate the JMX and admin
> page reporting that's there at the moment, but which should be more
> extensible). The patch includes a change to RequestHandlerBase showing how
> this could work. The idea would be to eventually replace the getStatistics()
> call on SolrInfoMBean with this instead.
> The next step would be to allow more MetricReporters to be defined in
> solrconfig.xml. The Metrics library comes with ganglia and graphite
> reporting modules, and we can add contrib plugins for both of those.
> There's some more general cleanup that could be done around SolrInfoMBean
> (we've got two plugin handlers at /mbeans and /plugins that basically do the
> same thing, and the beans themselves have some weirdly inconsistent data on
> them - getVersion() returns different things for different impls, and
> getSource() seems pretty useless), but maybe that's for another issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
