[ 
https://issues.apache.org/jira/browse/SOLR-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769476#comment-15769476
 ] 

Andrzej Bialecki  commented on SOLR-9880:
-----------------------------------------

I understand your concern. However, these two reporters seemed like a natural 
addition for several reasons:
* they are already a part of the Metrics distribution,
* they are maintained in the upstream package.
* they integrate with popular systems,
* in particular, Graphite protocol is so dead simple that it could be re-used 
by other systems, too - it just sends plain-text lines to a socket, with the 
name of the metric, its value and timestamp separated by space:
{code}
myPrefix.solr.node.cores.lazy 0 1482394715
myPrefix.solr.node.cores.loaded 1 1482394715
myPrefix.solr.node.cores.unloaded 0 1482394715
{code}

But you raise a good point - we should provide a file-based reporter too, as 
the lowest common denominator reporting mechanism... In fact, one is already 
included in the Metrics distribution ;) - the {{Slf4jReporter}} - and it's 
trivial to add a wrapper. This reporter could use a Logger per metrics group 
(configurable), so it should be easy to tweak the logging configuration so that 
its output goes to separate file(s) with rolling.

> Add Ganglia and Graphite metrics reporters
> ------------------------------------------
>
>                 Key: SOLR-9880
>                 URL: https://issues.apache.org/jira/browse/SOLR-9880
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>            Priority: Minor
>             Fix For: master (7.0), 6.4
>
>
> Originally SOLR-4735 provided implementations for these reporters (wrappers 
> for Dropwizard components to use {{SolrMetricReporter}} API).
> However, this functionality has been split into its own issue due to the 
> additional transitive dependencies that these reporters bring:
> * Ganglia:
> ** metrics-ganglia, ASL, 3kB
> ** gmetric4j (Ganglia RPC implementation), BSD, 29kB
> * Graphite
> ** metrics-graphite, ASL, 10kB
> ** amqp-client (RabbitMQ Java client, marked optional in pom?), ASL/MIT/GPL2, 
> 190kB
> IMHO these are not very large dependencies, and given the useful 
> functionality they provide it's worth adding them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to