[ 
https://issues.apache.org/jira/browse/LUCENE-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15776689#comment-15776689
 ] 

Paul Elschot commented on LUCENE-7602:
--------------------------------------

The lucene patch replaces the use of IdentityHashMap in ValueSource.java by a 
ContextMap, because I think it is wrong to use an IdentityHashMap there. 
Strings are used as keys, and Strings are not unique objects in java.

However, this conflicts somewhat with the way ContextMap is used in solr. There 
QueryContext needs an IdentityHashMap, but the solr tests pass even with the 
patch applied.

> Fix compiler warnings for ant clean compile
> -------------------------------------------
>
>                 Key: LUCENE-7602
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7602
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Paul Elschot
>            Priority: Minor
>              Labels: build
>             Fix For: trunk
>
>         Attachments: LUCENE-7602-ContextMap-lucene.patch, 
> LUCENE-7602-ContextMap-solr.patch, LUCENE-7602.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to