Mike Drob created SOLR-9937:
-------------------------------
Summary: StandardDirectoryFactory::move never uses more efficient
implementation
Key: SOLR-9937
URL: https://issues.apache.org/jira/browse/SOLR-9937
Project: Solr
Issue Type: Bug
Security Level: Public (Default Security Level. Issues are Public)
Reporter: Mike Drob
{noformat}
Path path1 = ((FSDirectory) baseFromDir).getDirectory().toAbsolutePath();
Path path2 = ((FSDirectory) baseFromDir).getDirectory().toAbsolutePath();
try {
Files.move(path1.resolve(fileName), path2.resolve(fileName),
StandardCopyOption.ATOMIC_MOVE);
} catch (AtomicMoveNotSupportedException e) {
Files.move(path1.resolve(fileName), path2.resolve(fileName));
}
{noformat}
Because {{path1 == path2}} this code never does anything and move always
defaults to the less efficient implementation in DirectoryFactory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
