[ https://issues.apache.org/jira/browse/SOLR-9934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812848#comment-15812848 ]
Mike Drob commented on SOLR-9934: --------------------------------- [~hossman] - is it worth converting all of the other invocations of {{assertU(delQ("*:*"))}} into calls to {{clearIndex()}}? Based on your description, it sounds like there might be a correctness bug lurking, but I'm not sure if it's actual or theoretical. I can create a new issue or upload a patch to this JIRA if you think it's worthwhile. > SolrTestCase.clearIndex should ensure IndexWriter.deleteAll is called > --------------------------------------------------------------------- > > Key: SOLR-9934 > URL: https://issues.apache.org/jira/browse/SOLR-9934 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Hoss Man > Assignee: Hoss Man > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9934.patch > > > Normal deleteByQuery commands are subject to version constraint checks due to > the possibility of out of order updates, but DUH2 has special support > (triggered by {{version=-Long.MAX_VALUE}} for use by tests to override these > version constraints and do a low level {{IndexWriter.deleteAll()}} call. A > handful of tests override {{SolrTestCaseJ4.clearIndex()}} to take advantage > of this (using copy/pasted impls), but given the intended purpose/usage of > {{SolrTestCaseJ4.clearIndex()}}, it seems like the the base method in > {{SolrTestCaseJ4}} should itself trigger this low level deletion, so tests > get this behavior automatically. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org