[ 
https://issues.apache.org/jira/browse/SOLR-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15818818#comment-15818818
 ] 

David Smiley commented on SOLR-9947:
------------------------------------

I don't think we should rush the naming on the eve of a feature freeze.

Thanks for the screenshot; though it's not clear how the patch retains both the 
old and new hierarchy; can you clarify?

I don't like "QUERY" nor "QUERYHANDLER" before it.  I suggest "SEARCHHANDLER", 
leaving "Query" terminology across Solr for literally either a Query object or 
query string to be parsed, but not as a synonym for searching generally.  Then 
SearchHandler could return SEARCHHANDLER... though perhaps at the base level a 
generic simply HANDLER (I dunno).

> Miscellaneous metrics cleanup
> -----------------------------
>
>                 Key: SOLR-9947
>                 URL: https://issues.apache.org/jira/browse/SOLR-9947
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Andrzej Bialecki 
>            Priority: Minor
>             Fix For: master (7.0), 6.4
>
>         Attachments: SOLR-9947-with-mbeans.patch, SOLR-9947.patch, 
> SOLR-9947.patch, screenshot-1.png
>
>
> Misc cleanup in metrics API to fix:
> # metrics reporting themselves under the wrong category
> # core container metrics are without a category



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to