Hi,
I fixed the compile warning. The more serious issue was a problem with Solr and Eclipse: It did not compile anymore, because the Solr UHighlighter implementation was using a Java-1.0-like inner class which was not nested but just top-level in same source file. IMHO, we should add a style check in “ant validate” to prevent this type of class declaration. Top-Level classes should always be in separate files or properly nested. Uwe ----- Uwe Schindler Achterdiek 19, D-28357 Bremen http://www.thetaphi.de <http://www.thetaphi.de/> eMail: [email protected] From: Uwe Schindler [mailto:[email protected]] Sent: Saturday, January 14, 2017 7:31 PM To: [email protected] Subject: RE: 6.4 release One final thing: Would it be possible to nuke the stupid unchecked warning caused by CollectorManager before release? We always tried to keep at least Lucene Core to compile without warnings, and now it’s really noisy and especially it is the first you see during build! Not a good sign :( I can try to fix this, but this would require to commit to 6.4 branch. Uwe ----- Uwe Schindler Achterdiek 19, D-28357 Bremen http://www.thetaphi.de <http://www.thetaphi.de/> eMail: <mailto:[email protected]> [email protected] From: Uwe Schindler [ <mailto:[email protected]> mailto:[email protected]] Sent: Saturday, January 14, 2017 7:25 PM To: <mailto:[email protected]> [email protected] Subject: RE: 6.4 release Hi Jim, Jenkins Jobs created and triggered for build! Uwe ----- Uwe Schindler Achterdiek 19, D-28357 Bremen http://www.thetaphi.de <http://www.thetaphi.de/> eMail: <mailto:[email protected]> [email protected] From: jim ferenczi [ <mailto:[email protected]> mailto:[email protected]] Sent: Saturday, January 14, 2017 4:03 PM To: <mailto:[email protected]> [email protected] Subject: Re: 6.4 release Thanks Uwe ! 2017-01-14 16:01 GMT+01:00 Uwe Schindler <[email protected] <mailto:[email protected]> >: Hi Jim, Thanks! I will update Jenkins this evening (Policeman and ASF). The first successful Java 9 build 152 was executed already on branch-6x, so we are in good shape also on Java 9 front. 😎 Uwe Am 14. Januar 2017 15:57:13 MEZ schrieb jim ferenczi <[email protected] <mailto:[email protected]> >: Hi, The release branch for 6.4 is pushed so the feature freeze phase has officially started. I don't have an admin account on Jenkins so any help would be appreciated. We need to copy the job for the new branch. No new features may be committed to the branch. Documentation patches, build patches and serious bug fixes may be committed to the branch. However, you should submit all patches you want to commit to Jira first to give others the chance to review and possibly vote against the patch. Keep in mind that it is our main intention to keep the branch as stable as possible. All patches that are intended for the branch should first be committed to the unstable branch, merged into the stable branch, and then into the current release branch. Normal unstable and stable branch development may continue as usual. However, if you plan to commit a big change to the unstable branch while the branch feature freeze is in effect, think twice: can't the addition wait a couple more days? Merges of bug fixes into the branch may become more difficult. Only Jira issues with Fix version "6.4" and priority "Blocker" will delay a release candidate build. Thanks, Jim -- Uwe Schindler Achterdiek 19, 28357 Bremen https://www.thetaphi.de
