[
https://issues.apache.org/jira/browse/LUCENE-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823660#comment-15823660
]
Adrien Grand commented on LUCENE-7623:
--------------------------------------
Thanks Alan, I just have some minor comments now, +1 otherwise!
- Let's use {{DoubleUnaryOperator}} rather than {{DoubleFunction<Double>}} and
{{ToDoubleBiFunction<Double,Double>}} rather tan {{BiFunction<Double, Double,
Double>}}
- Let's make {{FunctionMatchQuery}} and {{FunctionScoreQuery}} final
- In {{FunctionScoreQuery}}, I think we should only ask for scores on the
wrapped weight if the values source needs scores, ie. {{Weight inner =
in.createWeight(searcher, needsScores && valuesSource.needsScores(), 1f);}}
- I think the tests could be improved by checking TopDocs.totalHits too?
Otherwise we might miss cases when the top docs are the same but one query
yields more results?
> Add FunctionScoreQuery and FunctionMatchQuery
> ---------------------------------------------
>
> Key: LUCENE-7623
> URL: https://issues.apache.org/jira/browse/LUCENE-7623
> Project: Lucene - Core
> Issue Type: New Feature
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Minor
> Attachments: LUCENE-7623.patch, LUCENE-7623.patch, LUCENE-7623.patch,
> LUCENE-7623.patch, LUCENE-7623.patch
>
>
> We should update the various function scoring queries to use the new
> DoubleValues API
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
