[ 
https://issues.apache.org/jira/browse/LUCENE-7644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828604#comment-15828604
 ] 

ASF subversion and git services commented on LUCENE-7644:
---------------------------------------------------------

Commit 8c2ef3bc7fbebe8105c2646c81489aa9393ad402 in lucene-solr's branch 
refs/heads/master from [~romseygeek]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8c2ef3b ]

LUCENE-7644: FieldComparatorSource.newComparator() doesn't need to throw 
IOException

This allos us to also remove the throws clause on SortField.getComparator(),
TopDocs.merge() and various Collector constructors


> FieldComparatorSource.newComparator() doesn't need to throw IOException
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-7644
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7644
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>             Fix For: 6.5
>
>         Attachments: LUCENE-7644.patch
>
>
> All IO operations on FieldComparator are done in .getLeafComparator(), so 
> there's no need to declare IOException on their constructors.
> This bubbles back up and lets us remove throws clauses from a number of 
> constructors, TopDocs.merge(), and so on.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to