[
https://issues.apache.org/jira/browse/LUCENE-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838767#comment-15838767
]
Michael McCandless commented on LUCENE-7656:
--------------------------------------------
I like this change! It's nice you see a perf gain on the OSM benchmarks. I
suppose it would help "big" distance queries more and maybe hurt "tiny"
distance queries, since it does the up front work (the {{DistancePredicate}},
but that's the right tradeoff.
It's a bit annoying that, if you use the {{IndexOrDocValuesQuery}}, all the
same up front work is done twice, and one of them won't be used; maybe we could
make it lazy? But that can wait, it's just an opto.
Since you use bit shifting, it looks like the number of effective cells may be
anywhere between 1024 and 4096 right? Do you think two straight integer
divisions instead, which could get us usually to 4096 cells, is too costly per
hit?
bq. maybe the way LatLonPointDistanceQuery computes relations between a box and
a circle relies on assumptions that are not met in this new code
I believe you are using it in essentially the same way as before, just
different sized cells, so this should be fine.
> Implement geo box and distance queries using doc values.
> --------------------------------------------------------
>
> Key: LUCENE-7656
> URL: https://issues.apache.org/jira/browse/LUCENE-7656
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-7656.patch, LUCENE-7656.patch
>
>
> Having geo box and distance queries available as both point and
> doc-values-based queries means we could use them with
> {{IndexOrDocValuesQuery}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
